Thank you so much for continuously supporting! Glad to be part of such a great helping community . So as you said the time approach can be tricky i have found another thing which is
eTag: The etag represents the overall state of an item (metadata and content)
cTag: The ctag specifically tracks changes to the item's content.
eTag and cTag we also get back as we get lastmodifieddatetime so i just try to use them instead ....so on close excel file i get the present eTag and cTag which is in graphAPI saved and when that service completed i call the next service which returns me eTag and cTag again which is after closing the file and i compare them with my on close values and if they are not changed take delay and check again untill they are change.... i have delay upto 45 or 50 seconds.... one thing which i have found very weired that even though eTag and cTag are changed the pdf changes can still take a second to be fully saved in the cloud of DRIVE ... even though i already had 2 seconds delay before we get our pdf still it came once wrong...so i just put another 2 seconds delay before calling the pdf service as you can see below....
I am doubting a bit on my approach now. i dont know either it is right or can cause problems later.... i have tested now with this code now pdf is being generated right with latest changes.... i have tested it around 50 times now.. what do you think about it?
// ========= Pre-close snapshot (baseline) =========
// Grab the current tags *right when the user closes the Excel window*.
// We will wait until OneDrive shows a version newer than this.
var baseMeta = Things["SmartPDFAssist.Data.Controller"].getSourceFileCTag({ folderName: "", fileName: "" });
// Expecting baseMeta to include eTag / cTag (and optionally hashes.quickXorHash)
var baseETag = baseMeta.eTag;
var baseCTag = baseMeta.cTag;
var baseHash = (baseMeta.hashes && baseMeta.hashes.quickXorHash) ? baseMeta.hashes.quickXorHash : undefined;
logger.info("Baseline -> eTag: " + baseETag + " | cTag: " + baseCTag + " | hash: " + (baseHash || "-"));
// ========= Backoff schedule (balanced correctness vs speed) =========
// Total wait ~60–70s max. Adjust if you see longer commits in practice.
var waits = [1000, 1000, 2000, 3000, 5000, 8000, 13000, 15000];
var ready = false;
var meta, curHash;
// ========= Poll until tags/hash change from baseline =========
for (var i = 0; i < waits.length; i++) {
pause(waits[i]); // wait before checking again to let OneDrive commit/version-bump
meta = Things["SmartPDFAssist.Data.Controller"].getSourceFileCTag({ folderName: "", fileName: "" });
curHash = (meta.hashes && meta.hashes.quickXorHash) ? meta.hashes.quickXorHash : undefined;
var changed =
(meta.eTag !== baseETag) ||
(meta.cTag !== baseCTag) ||
(!!baseHash && !!curHash && curHash !== baseHash); // use content hash if both sides available
logger.info(
"Wait " + (i + 1) + "/" + waits.length + " (" + waits[i] + " ms) -> " +
"eTag: " + meta.eTag + " (base " + baseETag + "), " +
"cTag: " + meta.cTag + " (base " + baseCTag + "), " +
"hash: " + (curHash || "-") + " (base " + (baseHash || "-") + "), " +
"changed=" + changed
);
if (changed) {
// small settle time even after version bump to avoid race with export
pause(2000);
ready = true;
break;
}
}
// ========= Generate PDF =========
if (ready) {
executeService();
logger.info("PDF generated after OneDrive version bump was detected.");
} else {
logger.warn("Timed out waiting for OneDrive version bump (~>60s). Generating PDF anyway.");
// IF no change has been done that means the cTag eTag would not change then we show the old pdf already.
executeService();
}
// ========= Helper =========
function executeService() {
pause(2000);
var pdfFile = Things["SmartPDFAssist.APICalls.Controller"].saveOneDriveFileAsPDF();
Things["SmartPDFAssist.FileRepository"].SaveBinary({
path: "/test/files/testfile.pdf",
content: pdfFile
});
}
